feat: add_inplace should be implemented in the curve_g1 package ( PROOF-663 ) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
reviewed
Sep 22, 2023
sxt/curve_g1/operation/add.h
Outdated
| // add_inplace | ||
| //-------------------------------------------------------------------------------------------------- | ||
| /* | ||
| p = p + q (q value is preserved but not const to satisfy concept requirements) |
There was a problem hiding this comment.
(q value is preserved but not const to satisfy concept requirements)
Why can't it be const and satisfy the concept?
There was a problem hiding this comment.
This was just my knowledge gap. I wasn't sure how to verify if it could be const without updating the cbindings to do MSM with curve_g1 elements.
I've updated it to const.
rnburn
approved these changes
Sep 25, 2023
jacobtrombetta
deleted the
feat/addition-inplace-for-curve_g1-PROOF-663
branch
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In order to perform MSM with elements on the G1 curve, the element concept in
sxt/base/curve/elementrequires anadd_inplacefunction be implemented. Theadd_inplaceimplementation is similar to theaddfunction with different parameters and two less temporary variables.What changes are included in this PR?
add_inplaceis added to theaddcomponent in thecurve_g1/operationspackage.addfunction is refactored to use theadd_inplaceimplementation internally.Are these changes tested?
Yes