-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cube and cutout unittests #90
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 8 8
Lines 1443 1443
=======================================
Hits 1363 1363
Misses 80 80 ☔ View full report in Codecov by Sentry. |
Thanks for this PR - I thought about it a bit more about testing the new
The logic here isn't exact, I would verify with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave it to others to decide if this tested all the various header differences, but these tests look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests look good to me! Just had one question on an assertion re: the CADENCEN0
header keyword for TICA. Other than that, I think this is ready for merge.
Updates to existing unit tests and adding new tests to account for changes in
CutoutFactory
(made in #88). Tests verify that cutouts are being made correctly from the new TICA cubes (without error arrays) and verify known differences in TICA vs. SPOC FFIs, cubes, and cutouts.Note, there is a placeholder unittest (
test_cube_cut.py::test_tica_cutout_error
) to remind us to go back to look at whether we can/should point the test to an existing TICA cube (one that does have the error array and will be among the last cubes to me re-built, e.g., Sector 27) that will be re-built later, to verify that cutouts can still be made from cubes with error array.