-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove units from mosaic level pipeline #1406
Comments
Comment by Nadia Dencheva on JIRA: We are removing units from the data arrays, i.e. removing quantities from the files. However, the data units is valuable information. How is this info stored in the files or is it TBD? |
TBD. Tyler and I talked a little about this. We are going to continue to have it in the rad schemas following Brett's suggestion here: |
Comment by Mairan Teodoro on JIRA: Draft PRs associated with this ticket:
|
Comment by Mairan Teodoro on JIRA: The results from removing the units are reported here: https://innerspace.stsci.edu/pages/viewpage.action?pageId=528888606 |
Issue RCAL-911 was created on JIRA by Eddie Schlafly:
Remove units from the mosaic level pipeline. This involves updates to rad (removing units from schemas), roman_datamodels (removing units from the data models) and romancal (removing units from the pipeline). The mosaic level pipeline uses fewer units than the ELP, so my expectation is that this will be much less involved than there. I believe it uses no reference files with units (though the photmjysr column in the ELP files carry units), so that will also make it easier. We should assume for the moment that that column will continue to have units, and so the mosaic level pipeline should remove them via .value; a later update to the ELP will remove those updates and require an update to the mosaic level pipeline to compensate.
I've given the epic as mosaic images in B15 since this touches the HLP, but we should migrate to a B16 epic when available.
The text was updated successfully, but these errors were encountered: