Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate release from push #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yosevu
Copy link
Contributor

@yosevu yosevu commented Aug 11, 2021

This means that two scripts are required to create and push a release, but it makes
it easier to create a specific version.

I also experimented with this to do the latest release and I didn't realize that I published the changes.

Example:

  1. npm run release release-as minor
  2. npm run release:push

This means that two scripts are required to create and push a release, but it makes
it easier to create specific version. For example:

1. `npm run release release-as minor`
2. `npm run release:push`
@jordanleven
Copy link
Contributor

jordanleven commented Aug 11, 2021

It looks like this repo might not have received the same updates as Sparkle or Safe Focus. It might be easier to bring this script into the repo if you were looking for an easier way to clean up the process.

@yosevu
Copy link
Contributor Author

yosevu commented Aug 11, 2021

Yes! That's perfect. I'll add that instead.

@jordanleven
Copy link
Contributor

Actually, I just remembered that Nate has an open PR for a slight modification to that process that would remove the use of next-standard-version (which spits out the version standard version would increment to). That package, I believe, might be outdated and throwing some security warnings. If you're interested in this newer appraoch, check out the PR here.

@yosevu
Copy link
Contributor Author

yosevu commented Aug 16, 2021

Got it. I'll plan to take a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants