Unreadable in dark mode

[ajorg-aws]

I have my browser / OS configured for dark mode. The extension is unreadable (white text on white background) in dark mode.

[alandtse]

Thanks. We probably need to implement something based on this. https://stackoverflow.com/questions/58880234/toggle-chrome-extension-icon-based-on-light-or-dark-mode-browser

We currently rely on diff match patch's html generation so that may have to be changed.

[casasmartinignacio]

Hi. I want to help with this but it works fine on my computer. I checked this on Windows and Chrome. What is your OS / Browser?

[ajorg-aws]

I'm more a fan of just following whatever prefers-color-scheme happens to say than I am of implementing any kind of toggle for a specific page or feature.

[alandtse]

I wasn't suggesting a toggle but just pointing out potential solutions for whoever wants to take a shot at it.

Perhaps a quick edit to the css will resolve this. https://github.com/spdx/spdx-license-diff/tree/master/app/styles. We probably need to edit the css to alter what's coming from dmp though since that's the meat of the display:
https://github.com/spdx/spdx-license-diff/blob/master/app/scripts/worker.js#L300

[ajorg-aws]

Hi. I want to help with this but it works fine on my computer. I checked this on Windows and Chrome. What is your OS / Browser?

Chrome on macOS at the moment, but the important thing is that the page I was viewing was viewed in dark mode.

You should be able to emulate the condition by going to, for example, https://raw.githubusercontent.com/spdx/spdx-license-diff/master/LICENSE and opening the Rendering tab (under More Tools) in the Developer Tools. There you can set prefers-color-scheme: dark at "Emulate CSS media features". There's some documentation about it here: https://developer.chrome.com/docs/devtools/rendering/emulate-css/ but it's admittedly a little tricky to get there.