-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpineInterface and SpineOpt commits to results DB #1003
Comments
We write it to the log - but we could write them to the DB too. |
That would be good. Often the log is not saved ad it’s usually actually multiple files and requires manual steps and may or may not have been written at all |
the two are good, because often the model doesn't solve or results are not written but the log is available. It is not very hard to setup and very easy to find the first file. |
We are now writing versions and elapsed time to a model Map parameter called 'solution_stats'. Please reopen if no good or if more stuff is needed. |
@manuelma this is really nice. It would be even better if we could include the following (in the case of a Benders Model):
|
I just added all that @DillonJ - it's very handy indeed. |
Looks like SpineOpt only writes the version and not the commit hash. I think it should write both since we can't be sure the version has been bumped. The commit hash is the only thing we can believe in. |
Often it's difficult to know which version of SpineOpt and SpineInterface was used for a set of old results or for an old model. For example, sometimes we will notice a performance degradation or an old DB doesn't work any more. In these cases it's very valuable to have this information.
It feels like the best solution would be for SpineOpt to write the commit of SpineInterface and SpineOpt that have been used to generate a set of results. Perhaps it could write new parameters (e,g, SpineOpt_Version and SpineInterface_Version the model object under the result altnerative in the output DB. While it's at it, maybe it could write total execution time and other useful information?
The text was updated successfully, but these errors were encountered: