Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature enhancement request: Add a "None return" in “class UltimateSDUpscale” #77

Open
mirabarukaso opened this issue May 9, 2024 · 0 comments

Comments

@mirabarukaso
Copy link

Hi there,

I really like your work, it's brilliant. To improve my experience, I'm currently working on my "74HC1G86 Logic Nodes", which can use a boolean trigger to enable/disable "SD Upscale" instead of wiring nodes.

But unfortunately I found that UltimateSDUpscale could not handle a "None" image as a valid input. I tried to send a 2x2 image into it, but it still took about 8 seconds to process the upscale. After investigating your source code, I found a simple way to solve this.

I'll post it here, hope you could accept it.

In nodes.py. Line 103, add the following codes.
It will check if there is a "None" type image came in, then "do nothing" but throw it back. That's all what I need.

if None is image: return (image, )

SN74HC1G86
Single 2-Input Exclusive-OR(XOR) Gate

A B Y
True True None
False False None
True False A
False True B

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant