Update the strip prefix logic for python libraries #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strip prefix logic to generate the imports for py_library rules was inaccurate.
Lets say you have a proto file at
a/b/c/d/e/f.proto
.If
stripPrefix
isa/b/c
then imports should be../..
since that willascend the import dir from the current dir
e
two levels toc
which will thenmake
from d.e import f_py_pb2
work.This updates the broken logic to implement this correct logic and adds a test to assert the same.
Fixes #362