Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep links with ENS names contaning non-latin chars cause endless redirect in Status browser #13983

Closed
churik opened this issue Sep 12, 2022 · 2 comments

Comments

@churik
Copy link
Member

churik commented Sep 12, 2022

Bug Report

Problem

Valid ENS names can contain emoji and basically any char according to https://docs.ens.domains/frequently-asked-questions
So 숨겨진보물.eth is correct ENS, which is resolved in wallet / chat key field to corresponding user
However, if I open it as a deep link, I've got endless redirect.

Expected behavior

Can see user profile after navigating to the app

Actual behavior

IMG_2635.MP4

Reproduction

  1. Open Status, create multiaccout
  2. Past in mobile browser: https://join.status.im/u/숨겨진보물.eth > Redirect me > Open in status

Additional Information

  • Status version: nightly 12/09/2022
  • Operating System: Android, iOS
@churik churik changed the title Deep links with ENS names with non-latin chars don't open Status Deep links with ENS names contaning non-latin chars don't open Status Sep 12, 2022
@churik churik changed the title Deep links with ENS names contaning non-latin chars don't open Status Deep links with ENS names contaning non-latin chars cause endless redirect in Status browser Sep 12, 2022
@Parveshdhull
Copy link
Member

Parveshdhull commented Sep 14, 2022

Adding for context:

(assoc (bidi/match-route routes uri) :uri uri :query-params (parse-query-params uri)))

(bidi/match-route routes uri) is not returning route

related issue juxt/bidi#206

(didn't tested in deep, needs more research)

@cammellos
Copy link
Member

Closing for now until we work on browser

@cammellos cammellos closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants