library: various tweaks

stephengold · Jun 18, 2024 · 3f11662 · 3f11662
1 parent fef0035
commit 3f11662
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/library/src/main/java/com/jme3/bullet/collision/shapes/BoxCollisionShape.java b/library/src/main/java/com/jme3/bullet/collision/shapes/BoxCollisionShape.java
@@ -143,6 +143,8 @@ public Vector3f getHalfExtents(Vector3f storeResult) {
      * Instantiate the configured {@code BoxShape}.
      */
     private void createShape() {
+        assert MyVector3f.isAllNonNegative(halfExtents) : halfExtents;
+
         MemorySession arena = PhysicsSpace.getArena();
         FVec3 vec3
                 = FVec3.of(arena, halfExtents.x, halfExtents.y, halfExtents.z);

diff --git a/library/src/main/java/com/jme3/bullet/collision/shapes/CollisionShape.java b/library/src/main/java/com/jme3/bullet/collision/shapes/CollisionShape.java
@@ -110,7 +110,7 @@ public Shape getJoltShape() {
     protected void setNativeObject(Shape joltShape) {
         Validate.nonNull(joltShape, "jolt shape");
 
-        assert this.joltShape == null : joltShape;
+        assert this.joltShape == null : this.joltShape;
         this.joltShape = joltShape;
     }
 }
diff --git a/library/src/main/java/com/jme3/bullet/collision/shapes/SphereCollisionShape.java b/library/src/main/java/com/jme3/bullet/collision/shapes/SphereCollisionShape.java
@@ -118,8 +118,8 @@ public boolean canScale(Vector3f scale) {
     private void createShape() {
         assert radius >= 0f : radius;
 
-        MemorySession arena = PhysicsSpace.getArena();
         SphereShapeSettings bss = SphereShapeSettings.of(radius);
+        MemorySession arena = PhysicsSpace.getArena();
         Shape shape = Jolt.use(bss, settings -> {
             return settings.create(arena);
         }).orThrow();

diff --git a/library/src/main/java/com/jme3/bullet/objects/PhysicsRigidBody.java b/library/src/main/java/com/jme3/bullet/objects/PhysicsRigidBody.java
@@ -438,6 +438,8 @@ public float getMass() {
      */
     @Override
     public void setPhysicsLocation(Vector3f location) {
+        Validate.finite(location, "location");
+
         Quaternion orientation = getPhysicsRotation(null);
         reposition(location, orientation);
     }