Enhance Error Handling and Entry Normalization in StorybookNormalizeAngularEntryPlugin #28217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
Description:
This PR introduces several key enhancements to the StorybookNormalizeAngularEntryPlugin to improve its reliability and maintainability within Storybook projects using Angular. The changes focus on robust error handling, support for asynchronous entry configurations, and a streamlined process for merging main and styles entry points to prevent multiple runtime bundles.
Changes:
Error Handling: Added try-catch blocks to capture and log errors when executing entry functions. This ensures that exceptions are handled gracefully and do not disrupt the Webpack build process.
Asynchronous Support: Modified the entry configuration handling to support asynchronous functions by awaiting their results, accommodating configurations that return promises.
Entry Merging: Refined the merging logic for main and styles entries to ensure that only one runtime bundle is generated, preventing the webpack_require.nmd is not a function error.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Clone the Repository:
Clone the repository and switch to the branch containing the changes.
Install Dependencies:
Install the necessary dependencies for the project.
Build the Project:
Build the project to ensure that the changes integrate correctly.
Run Automated Tests:
Execute existing automated tests to ensure no existing functionality is broken.
Documentation
MIGRATION.MD
Checklist for Maintainers
[ x] When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
[x ] Make sure this PR contains one of the labels below:
Available labels
- `cleanup`: Minor cleanup style change. Will not show up in release changelog.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>