Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaborator - user not able to login to accepts the invite. #213

Open
andsus opened this issue Jul 7, 2023 · 6 comments
Open

Collaborator - user not able to login to accepts the invite. #213

andsus opened this issue Jul 7, 2023 · 6 comments
Labels
application-feedback Bugs or anything else to improve the sample Todo application bug Something isn't working

Comments

@andsus
Copy link

andsus commented Jul 7, 2023

What's going wrong and not working?

Steps:

  1. User A invites user B (Actions, click user B on drop down)
  2. User A sees "You successfully shared your todo with the user B . Once the user accepts the invite, you'll see them as a collaborator on your todo."
  3. User B got email notification:
  4. Hi user B

someone shared a Todo from https://app.stratospheric.dev/ with you.

Information about the shared Todo item:

Title: Let's build
Description: Let's build the document
Priority: LOW

You can accept the collaboration by clicking this link: https://app.stratospheric.dev/todo/1/collaborations/2/confirm?token=f59f6892-d4c2-4374-803a-540e42fae860

  1. When B user accept by click the link, it takes to cognito login.
  2. User B try to login with correct crendential, but always came back as user name password not correct.

How do I trouble shoot the problem?
What would be the problem.

Thanks
Kind regards,
Stratospheric

Expected outcome

User B should be able to authenticated and authorized to accept invitation.

On application.yaml, the external_url is set to:
custom:
invitation-codes: DUKE, HELLO_WORLD, STRATOSPHERIC # TODO: outsource them -> e.g. env variable or database
sharing-queue: stratospheric-todo-sharing
external-url: https://app.devops.prime-video.amazon.dev/

public TodoSharingListener(
MailSender mailSender,
TodoCollaborationService todoCollaborationService,
@value("${custom.auto-confirm-collaborations}") boolean autoConfirmCollaborations,
@value("${custom.confirm-email-from-address}") String confirmEmailFromAddress,
@value("${custom.external-url}") String externalUrl) {
this.mailSender = mailSender;
this.todoCollaborationService = todoCollaborationService;
this.autoConfirmCollaborations = autoConfirmCollaborations;
this.confirmEmailFromAddress = confirmEmailFromAddress;
this.externalUrl = externalUrl;
}

Why TodoSharingListener.listenToSharingMessages() got https://app.stratospheric.dev/ instead of https://app.devops.prime-video.amazon.dev/

No response

@andsus andsus added application-feedback Bugs or anything else to improve the sample Todo application triage Waiting on feedback from the maintainers labels Jul 7, 2023
@andsus
Copy link
Author

andsus commented Jul 9, 2023

Apparently, there's an issue with ECS cluster task not updating, after latest image is pushed to ECR.
I've run the aws ecs update-service --force to take redeploy.
Is there any npm run task associated with update-servce? I ran npm run service:deploy .. but it does not update ecs to redeploy.

@BjoernKW
Copy link
Contributor

BjoernKW commented Jul 9, 2023

@andsus So, if I understand this correctly, the issue is the external URL not being updated from https://app.stratospheric.dev/ to https://app.devops.prime-video.amazon.dev/ after a new deployment?

The ServiceApp in the project's cdk folder should usually take care of that. Since we're using CDK for deployments, there should be no need to manually call update-service from the CLI.

Can you provide a link to a GitHub repository with a project that experiences this issue?

@BjoernKW BjoernKW added bug Something isn't working and removed triage Waiting on feedback from the maintainers labels Jul 9, 2023
@andsus
Copy link
Author

andsus commented Jul 9, 2023

@BjoernKW
Sure, here's the repo https://github.com/andsus/todo-app.git

@BjoernKW
Copy link
Contributor

BjoernKW commented Jul 9, 2023

@rieckpil Do you have an idea as to what this issue might be caused by? The code in the linked repository looks correct to me.

@rieckpil
Copy link
Contributor

rieckpil commented Jul 10, 2023

If the URL is pointing to https://app.stratospheric.dev and you change it inside your application.yml afterwards, you have to re-deploy the whole application.

If your re-deployment fails, I would take a look at that, as from the code perspective it looks fine.

To manually trigger a new service deployment, you need to attach the Docker Image Tage you want to deploy:

npm run service:deploy -- -c dockerImageTag=YOUR_IMAGE_TAG_WITH_UPDATED_APPLICATION_YML

Make sure to previously push a new Docker Image to the ECR and use x64 for the CPU arch.

@andsus
Copy link
Author

andsus commented Jul 10, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-feedback Bugs or anything else to improve the sample Todo application bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants