Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local-aws-infrastructure.sh not invoked #259

Open
giuliopulina opened this issue Feb 7, 2024 · 1 comment
Open

local-aws-infrastructure.sh not invoked #259

giuliopulina opened this issue Feb 7, 2024 · 1 comment
Labels
application-feedback Bugs or anything else to improve the sample Todo application

Comments

@giuliopulina
Copy link

giuliopulina commented Feb 7, 2024

What's going wrong and not working?

Hi,

with the current Localstack configuration, it seems that the script local-aws-infrastructure.sh is not invoked.
The main issue is that Localstack container is now based on the LATEST image, and, since v2, the default path for initialization hooks has been changed to /etc/localstack/init/ready.d (see Localstack - init hooks) .

Expected outcome

Localstack should initialize AWS resources during container startup.

Issue can be fixed by changing the following line:

./src/test/resources/localstack/local-aws-infrastructure.sh:/docker-entrypoint-initaws.d/init.sh

to this one:

./src/test/resources/localstack/local-aws-infrastructure.sh:/etc/localstack/init/ready.d/init.sh

Furthermore, the following improvements can be made:

  • set a static version on localstack image (current latest is 3.1.0)
  • remove deprecated environment variables (DEFAULT_REGION, USE_SINGLE_REGION) and set the variable AWS_DEFAULT_REGION=eu-central-1 at the top of local-aws-infrastructure.sh
@giuliopulina giuliopulina added application-feedback Bugs or anything else to improve the sample Todo application triage Waiting on feedback from the maintainers labels Feb 7, 2024
@rieckpil
Copy link
Contributor

rieckpil commented Feb 7, 2024

Thanks for reporting it. Indeed, LocalStack improved a lot and we "just" bumped the version. We'll take a closer look and improve it 👍

@rieckpil rieckpil removed the triage Waiting on feedback from the maintainers label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-feedback Bugs or anything else to improve the sample Todo application
Projects
None yet
Development

No branches or pull requests

2 participants