Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting theme options should not force base to light #8951

Open
2 tasks done
w-tv opened this issue Jun 20, 2024 · 1 comment
Open
2 tasks done

Setting theme options should not force base to light #8951

w-tv opened this issue Jun 20, 2024 · 1 comment
Labels
feature:theming Related to themes type:enhancement Requests for feature enhancements or new features

Comments

@w-tv
Copy link

w-tv commented Jun 20, 2024

Checklist

  • I have searched the existing issues for similar feature requests.
  • I added a descriptive title and summary to this issue.

Summary

Consider https://docs.streamlit.io/develop/concepts/configuration/theming

I'd like to use primaryColor to change the accent color of my app. However, it works equally well in light and dark mode, and I would like users to continue to get their system defaults with regard to light mode / dark mode.

Currently, ' If base itself is omitted, it defaults to "light" '. While it's nice that this is documented correctly, the behavior is undesirable. Instead, both themes should be modified, unless a base is specified.

@w-tv w-tv added the type:enhancement Requests for feature enhancements or new features label Jun 20, 2024
Copy link

To help Streamlit prioritize this feature, react with a 👍 (thumbs up emoji) to the initial post.

Your vote helps us identify which enhancements matter most to our users.

Visits

@LukasMasuch LukasMasuch added the feature:theming Related to themes label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:theming Related to themes type:enhancement Requests for feature enhancements or new features
Projects
None yet
Development

No branches or pull requests

2 participants