fix(typegen): omit `columns` when querying tables #585

soedirgo · 2023-06-06T10:58:47Z

Or views etc. This can be expensive on a complex enough schema and can easily trip over the 15s timeout.

Instead, query all columns separately, which should hopefully be less taxing and easier to plan.

Also omit excluded schemas when listing tables/views/etc.

Benchmark results on 100 tables with 100 columns each:

Before:

  Time (mean ± σ):      8.134 s ±  0.211 s    [User: 0.094 s, System: 0.017 s]
  Range (min … max):    7.857 s …  8.569 s    10 runs

After:

  Time (mean ± σ):      1.787 s ±  0.113 s    [User: 0.094 s, System: 0.016 s]
  Range (min … max):    1.648 s …  1.980 s    10 runs

Or views etc. This can be expensive on a complex enough schema and can easily trip over the 15s timeout. Instead, query all columns separately, which should hopefully be less taxing and easier to plan. Also omit excluded schemas when listing tables/views/etc.

src/server/routes/generators/typescript.ts

src/server/templates/typescript.ts

Co-authored-by: Kevin Grüneberg <[email protected]>

src/server/templates/typescript.ts

kevcodez

Assuming you tested this thoroughly, can't judge the functionality, but the code LGTM! And the performance improvements...

soedirgo requested review from a team as code owners June 6, 2023 10:58

chore: run prettier

2feb504