Support cross-platform apps and directories #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffix on windows) and temp directory locations
sverrirs
reviewed
Nov 28, 2022
| @@ -0,0 +1,17 @@ | |||
| [tool.poetry] | |||
There was a problem hiding this comment.
Please exclude this python poetry configuration file from your commit
sverrirs
reviewed
Nov 28, 2022
| import tempfile # platform-independent tempoary files and directories | ||
|
|
||
| # default filenames | ||
| MP4BOX_DEFAULT_FILENAME = "mp4box" if not (platform.system() == "Windows") else "mp4box.exe" |
There was a problem hiding this comment.
Consider simplifying the conditional here to not use a negative, easier to read, also consider making the comparison case insensitive, i.e.
"mp4box.exe" if platform.system().casefold() == "Windows".casefold() else "mp4box"
sverrirs
reviewed
Nov 28, 2022
| @@ -55,6 +61,8 @@ def runMain(): | |||
|
|
|||
| # Construct the argument parser for the commandline | |||
| args = parseArguments() | |||
|
|
|||
| print(args) | |||
sverrirs
reviewed
Nov 28, 2022
| def findffmpeg(path_to_ffmpeg_install=None, working_dir=None): | ||
| if( not path_to_ffmpeg_install is None and os.path.isfile(os.path.join(path_to_ffmpeg_install, "ffmpeg.exe")) ): | ||
| return os.path.join(path_to_ffmpeg_install, "ffmpeg.exe") | ||
| def findffmpeg(path_to_ffmpeg_install=None, working_dir=None, ffmpeg_filename="ffmpeg"): |
There was a problem hiding this comment.
Could you please make the same type of constant for FFMPEG as you've done for mp4box otherwise the script breaks on Windows
sverrirs
reviewed
Nov 28, 2022
| @@ -611,4 +619,5 @@ def parseArguments(): | |||
|
|
|||
| # If the script file is called by itself then execute the main function | |||
| if __name__ == '__main__': | |||
| print("HELLO") | |||
There was a problem hiding this comment.
Please remove this print statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for running on Macs (and maybe other platforms) by using cross-platform libraries to identify the temp directory and file names.