Add common compilation flags to tests [BUILD-448] #25
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jungleraptor
previously approved these changes
Dec 13, 2022
| """Wraps cc_test to enforce Swift testing conventions. | ||
|
|
||
| Args: | ||
| name: A unique name for this rule. | ||
| type: Specifies whether the test is a unit or integration test. | ||
| common_c_opts: Bool flag that indicates if common compilation flags will be added. Default False. |
There was a problem hiding this comment.
Were there things that failed to build unless this was an optional parameter?
Guessing in a lot of cases we need to remove certain flags via nocopts.
| kwargs["name"] = name | ||
| kwargs["tags"] = (kwargs["tags"] if "tags" in kwargs else []) + [type] | ||
| kwargs["linkstatic"] = (kwargs["linkstatic"] if "linkstatic" in kwargs else True) |
There was a problem hiding this comment.
What's the reason for making this the default?
There was a problem hiding this comment.
I went back and forth but lets discuss a little more in our meeting tomorrow. Basically I don't want to have that bool flag become a permanent part of the API and am a little concerned that it might become difficult to remove it if we merge these changes as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds common compilation flags to
swift_cc_test_libraryand addscommon_c_optsflag toswift_cc_testwhich adds common compilation flags.This PR sets the
linkstaticflag toTrueinswift_cc_test.Tested here: