Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Remove PUT ServiceDefinitions #184

Open
seilc1 opened this issue Oct 30, 2018 · 0 comments
Open

Remove PUT ServiceDefinitions #184

seilc1 opened this issue Oct 30, 2018 · 0 comments

Comments

@seilc1
Copy link
Contributor

seilc1 commented Oct 30, 2018

Problem

ServiceDefinitions should be defined via the application yml entry com.swisscom.cloud.sb.broker.serviceDefinitions this should be the source of truth. As it is still possible to update a serviceDefinition via the REST Endpoint this can lead to unexpected behaviours:

ServiceDefinitions: NULL
. StartUp - ServiceDefinitionInitializer sets ServiceDefinitions to the application.yml configuration
ServiceDefinitions: Source-Of-Truth
. PUT to ServiceDefinition
ServiceDefinitions: Modified
. Restart - ServiceDefinitionInitializer sets ServiceDefinitions to the application.yml configuration
ServiceDefinitions: Source-Of-Truth

This is confusing if you expected to have always the modified version.

Solution: Remove the PUT Endpoint for ServiceDefinitions and the unused code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant