X64 AESNI assembler routines corrupt XMM6-XMM15 which the Win64 calling convention expects to be preserved

[zunzster]

This corruption can be observed when compiling with Optimization on and local Double variables are stored in XMM6 onwards.

Code blocks similar to the {$IFNDEF LINUX} blocks in sha256_sse4 from Intel are needed for the X64 assembler routines which use XMM6-XMM15.

aesni(en|de)crypt128 (xmm6-xmm11), aesni(en|de)crypt192 (xmm6-xmm13), aesni(de|en)crypt256 (xmm6-xmm15)
MakeDecrKeyAesNi (xmm6-xmm7), AesNiEncryptOFB_128 (xmm6-xmm11), AesNiEncryptOFB_256 (xmm6-xmm15).

[synopse]

Please switch to mORMot 2, which already includes the fix.

[zunzster]

Thanks, Arnaud. I figured that was likely the case.

We're only using a selected few pieces of mORMot v1 so I'll look at what is involved in switching those to mORMot v2. I've coded up the required fixes in case anyone else wants them.

[synopse]

You are welcome to make a pull request here, of course!