Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA id's #24

Open
gbowne1 opened this issue Aug 19, 2022 · 2 comments
Open

ARIA id's #24

gbowne1 opened this issue Aug 19, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Website 0.1.0

Comments

@gbowne1
Copy link
Member

gbowne1 commented Aug 19, 2022

I tested index.php running in localhost from PHP Server in Google Chrome's built in Google Lighthouse.

The span classes inside index.php do not have unique ARIA id's

These include:

  • div.modal-content > div.modal-body > div.input-group > span#txtUserName
    <span class="input-group-text" id="txtUserName">

  • div.modal-content > div.modal-body > div.input-group > span#txtUserName
    <span class="input-group-text" id="txtUserName">

  • div.modal-content > div.modal-body > div.input-group > span#txtPassword
    <span class="input-group-text" id="txtPassword">

  • div.modal-content > div.modal-body > div.input-group > span#txtPassword
    <span class="input-group-text" id="txtPassword">

  • div.modal-content > div.modal-body > div.input-group > span#txtPassword
    <span class="input-group-text bg-transparent" id="txtPassword">

  • div.modal-content > div.modal-body > div.input-group > span#txtPassword
@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 19, 2022
@gbowne1 gbowne1 added this to the Website 0.1.0 milestone Aug 20, 2022
@gbowne1
Copy link
Member Author

gbowne1 commented Aug 20, 2022

Also make sure that the footer social icons have ARIA text labels

@gbowne1
Copy link
Member Author

gbowne1 commented Sep 11, 2022

@taotnpwaft/website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Website
Status: Todo
Milestone
Website 0.1.0
Development

No branches or pull requests
3 participants
@gbowne1 @pranavmadhu01 @Rmichal503