Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Boot Node / Child Node mess #24

Open
tatmanblue opened this issue Apr 17, 2024 · 2 comments
Open

Fix Boot Node / Child Node mess #24

tatmanblue opened this issue Apr 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@tatmanblue
Copy link
Owner

tatmanblue commented Apr 17, 2024

The design was that boot node and child nodes are the same service just configured to run as either. For the most part this is true.

The mess lies in the types consumed in the service, and particularly with the event pub/sub system and the ledger system(s).

Not sure what the best approach is to correct these. Refactoring around injection, interfaces and maybe implement a strategy pattern or something similar.

Note: this issue is mostly another one of these issues that will be fixed over time as other work is completed.

@tatmanblue tatmanblue added the bug Something isn't working label Apr 17, 2024
@tatmanblue
Copy link
Owner Author

Some of this can be cleared up by

  1. making IServiceProvider parameter on functions
  2. using Factory Providers for LedgerIndex etc...

@tatmanblue
Copy link
Owner Author

It maybe possible that LedgerManager and ClientLedgerManager can split out from inheritance tree (unless theres an abstract layer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant