Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global service ID conflicts when m2if is used inside another Symfony app #166

Open
adhocore opened this issue Jan 21, 2020 · 1 comment
Open

Comments

@adhocore
Copy link
Contributor

Some service IDs like configuration, loggers, connection are used in global context:
ref: https://github.com/techdivision/import/blob/15.x/symfony/Resources/config/services.xml

it would be best to have them namespaced like so:
import.configuration, import.loggers, import.connection

to not break BC, we can alias them to their original IDs.

(PS: there can be more such service IDs than mentioned above)

@wagnert wagnert self-assigned this Jan 21, 2020
@wagnert
Copy link
Member

wagnert commented Jan 21, 2020

@adhocore You're right, this are technical debts we've to solve. I'll add this to the next release.

@wagnert wagnert added this to Selected in Pacemaker Community Jan 21, 2020
@wagnert wagnert removed their assignment Apr 8, 2020
@wagnert wagnert removed this from the 16.0.0 milestone Apr 29, 2020
@wagnert wagnert moved this from Selected to ToDo in Pacemaker Community Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants