Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature nightly? #15

Open
dobromyslov opened this issue Jan 21, 2022 · 0 comments
Open

Remove feature nightly? #15

dobromyslov opened this issue Jan 21, 2022 · 0 comments

Comments

@dobromyslov
Copy link

I copied your implementation of the BufReader, tested it with new Rust and discovered that it compiles without nightly feature.
Looks like Rust already supports const generic. Details: https://blog.rust-lang.org/2021/02/26/const-generics-mvp-beta.html

Maybe it's time to remove the nightly feature?
vmx added a commit to vmx/core2 that referenced this issue Jan 28, 2022
@vmx
Use stable features where possible
3df8a90 
`io::copy()` as well as the `BufReader`/`BufWriter` don't need nightly
Rust anymore as they the features needed are available on more recent
stable Rust versions. This commit bumps the MSRV to 1.55.

Closes technocreatives#15.
@vmx vmx mentioned this issue Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use stable features where possible vmx/core2
1 participant
@dobromyslov