From 533a3431a0b49547a48236fa52eecdf4bdc69eec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferm=C3=ADn=20Gal=C3=A1n=20M=C3=A1rquez?= Date: Wed, 17 Apr 2024 08:52:09 +0200 Subject: [PATCH] Apply suggestions from code review --- doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_mysql_sink.md | 4 ++-- .../flume_extensions_catalogue/ngsi_oracle_sink.md | 4 ++-- .../flume_extensions_catalogue/ngsi_postgresql_sink.md | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_mysql_sink.md b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_mysql_sink.md index 2aee1170d..c6ad3d435 100644 --- a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_mysql_sink.md +++ b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_mysql_sink.md @@ -235,8 +235,8 @@ If `attr_persistence=colum` then `NGSIMySQLSink` will persist the data within th | mysql\_username | no | root | `root` is the default username that is created automatically | | mysql\_password | no | N/A | Empty value as default (no password is created automatically) | | mysql\_maxPoolSize | no | 3 | Max number of connections per database pool | -| mysql\_maxPoolIdle | no | 2 | Max number of connections idle per database pool | -| mysql\_minPoolIdle | no | 0 | Min number of connections idle per database pool | +| mysql\_maxPoolIdle | no | 2 | Max number of idle connections per database pool | +| mysql\_minPoolIdle | no | 0 | Min number of idle connections per database pool | | mysql\_minPoolIdleTimeMillis | no | 10000 | minimum amount of time an idle connection before is eligible for eviction | | mysql\_options | no | N/A | optional connection parameter(s) concatinated to jdbc url if necessary
When `useSSL=true&requireSSL=false` is set to `mysql_options`, jdbc url will become like jdbc:mysql://mysql.example.com:3306/fiwareservice?useSSL=true&requireSSL=false| | attr\_persistence | no | row | row or column diff --git a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_oracle_sink.md b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_oracle_sink.md index 85837fbcf..5135b6379 100644 --- a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_oracle_sink.md +++ b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_oracle_sink.md @@ -236,8 +236,8 @@ If `attr_persistence=colum` then `NGSIOracleSQLSink` will persist the data withi | oracle\_password | no | oracle | `oracle` is the default for default username | | oracle\_database | no | xe | `xe` is the default database avaiable in oracle 11g XE (express edition) | | oracle\_maxPoolSize | no | 3 | Max number of connections per database pool | -| oracle\_maxPoolIdle | no | 2 | Max number of connections idle per database pool | -| oracle\_minPoolIdle | no | 0 | Min number of connections idle per database pool | +| oracle\_maxPoolIdle | no | 2 | Max number of idle connections per database pool | +| oracle\_minPoolIdle | no | 0 | Min number of idle connections per database pool | | oracle\_minPoolIdleTimeMillis | no | 10000 | minimum amount of time an idle connection before is eligible for eviction | | oracle\_options | no | N/A | optional connection parameter(s) concatinated to jdbc url if necessary
When `useSSL=true&requireSSL=false` is set to `oracle_options`, jdbc url will become like jdbc:oracle://oracle.example.com:3306/fiwareservice?useSSL=true&requireSSL=false| | attr\_persistence | no | row | row or column diff --git a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_postgresql_sink.md b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_postgresql_sink.md index 2b7d021d0..4fac5137c 100644 --- a/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_postgresql_sink.md +++ b/doc/cygnus-ngsi/flume_extensions_catalogue/ngsi_postgresql_sink.md @@ -269,8 +269,8 @@ Coming soon. | postgresql\_username | no | postgres | `postgres` is the default username that is created automatically when install | | postgresql\_password | no | N/A | Empty value by default (No password is created when install) | | postgresql\_maxPoolSize | no | 3 | Max number of connections per database pool | -| postgresql\_maxPoolIdle | no | 2 | Max number of connections idle per database pool | -| postgresql\_minPoolIdle | no | 0 | Min number of connections idle per database pool | +| postgresql\_maxPoolIdle | no | 2 | Max number of idle connections per database pool | +| postgresql\_minPoolIdle | no | 0 | Min number of idle connections per database pool | | postgresql\_minPoolIdleTimeMillis | no | 10000 | minimum amount of time an idle connection before is eligible for eviction | | postgresql\_options | no | N/A | optional connection parameter(s) concatinated to jdbc url if necessary
When `sslmode=require` is set to `postgresql_options`, jdbc url will become like jdbc:postgresql://postgresql.example.com:5432/postgres?sslmode=require| | attr\_persistence | no | row | row or column. |