Merge pull request #2377 from telefonicaid/task/null_attribute_value_url

Insert null attribute as is in feature table
telefonicaid · Jun 5, 2024 · 7de533e · 7de533e
2 parents af91598 + e4af776
commit 7de533e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1 +1 @@
-
+- [cygnus-arcgis] Insert null attribute as is in feature table (#2376)
diff --git a/cygnus-ngsi/src/main/java/com/telefonica/iot/cygnus/sinks/NGSIArcgisFeatureTableSink.java b/cygnus-ngsi/src/main/java/com/telefonica/iot/cygnus/sinks/NGSIArcgisFeatureTableSink.java
@@ -631,11 +631,17 @@ protected void jsonElementToFeatureAttr(String attrName, String attrType, JsonEl
                             // Try to insert as Double
                             feature.addAttribute(attrName, Double.parseDouble(attrValue.toString()));
                         } catch (NumberFormatException e3) {
-                            // If all fails, insert as String
                             LOGGER.warn(
                                     "[NGSIArcgisAggregator] Unquoted String attribute: " + attrName + ":" + attrValue);
-                            String strValue = URLDecoder.decode(attrValue.toString());
-                            feature.addAttribute(attrName, strValue);
+                            // If all fails, insert as String, except if null
+                            if (attrValue != null) {
+                                String strValue = URLDecoder.decode(attrValue.toString());
+                                feature.addAttribute(attrName, strValue);
+                            } else {
+                                // Insert null as is
+                                feature.addAttribute(attrName, attrValue);
+                            }
+
                         }
                     }
                 }