Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STH Aggregator does not support more than one event #2303

Open
ctc-watanabe opened this issue Sep 15, 2023 · 2 comments
Open

STH Aggregator does not support more than one event #2303

ctc-watanabe opened this issue Sep 15, 2023 · 2 comments

Comments

@ctc-watanabe
Copy link

Hi, the following comments and code indicate that the STH Aggregator does not support more than one event and persists events one at a time.

for (NGSIEvent event : events) {
// Current STH Aggregator does not allow more than one event
// but an STH aggregation is big enough to be persited each time
STHAggregator aggregator = new STHAggregator();
aggregator.initialize(event);
aggregator.aggregate(event);
// Persist the aggregation
aggregator.persist(this.getName());
} // for

However, when there are many notifications from Orion to Cygnus and many updated attributes (tens to hundreds of rps), STHSink cannot keep up and the Channel fills up over time.

We would like the STH Aggregator to support multiple events (e.g., update events in a batch at once), but please let us know if this is in your future plans.

Thank you in advance.

@ctc-watanabe
Copy link
Author

According to #571, is it difficult to implement?

@AlvaroVega
Copy link
Member

AlvaroVega commented Sep 15, 2023

@ctc-watanabe I'm afraid there is nothing about STH aggregator in new cygnus roadmap: #2292
Anyway any contribution is welcome. Depending on your experience with cygnus source code could could be not so difficult to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants