Not using $schema_name_error_log, using $database_name_error_log instead

[danielvillalbamota]

Description

The "..._error_log" table is not getting the name of the schema as documentation refers, but the name of database.

fiware-cygnus/doc/cygnus-common/installation_and_administration_guide/error_persistance.md

Line 21 in 808bf1f

$schema_name_error_log

How-to reproduce

This issue can be reproduced using a sink with datamodel dm-by-fixed-entity-type-database-schema.

Expected behavior

I would expect the table's name as documentation shows.

[AlvaroVega]

Current implementation is using:

fiware-cygnus/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/sql/SQLBackendImpl.java

Lines 587 to 593 in 808bf1f

	public void createErrorTable(String dataBase, String schema)
	throws CygnusRuntimeError, CygnusPersistenceError {
	// the default table for error log will be called the same as the destination name
	String errorTableName = dataBase + DEFAULT_ERROR_TABLE_SUFFIX;
	if (sqlInstance == SQLInstance.POSTGRESQL) {
	errorTableName = schema + "." + dataBase + DEFAULT_ERROR_TABLE_SUFFIX;
	}

schema + "." + dataBase + DEFAULT_ERROR_TABLE_SUFFIX;

So maybe documentation should be updated to reflect it

[fgalan]

PR #2404

@danielvillalbamota should this issue be closed?