From 615a015fbdc30cc2fd4011637c1560ef86a3d6ab Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Wed, 25 Sep 2024 09:34:47 +0200 Subject: [PATCH 1/2] add more info about errors when crateInstanceFromJson geometry --- .../iot/cygnus/backends/arcgis/model/MultiPoint.java | 4 ++-- .../telefonica/iot/cygnus/backends/arcgis/model/Point.java | 4 ++-- .../telefonica/iot/cygnus/backends/arcgis/model/PolyLine.java | 4 ++-- .../telefonica/iot/cygnus/backends/arcgis/model/Polygon.java | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/MultiPoint.java b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/MultiPoint.java index 555f4292f..0f433f536 100644 --- a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/MultiPoint.java +++ b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/MultiPoint.java @@ -133,8 +133,8 @@ public static Geometry createInstanceFromJson(JsonObject json) throws ArcgisExce try { return new MultiPoint(json.get(POINTS_TAG).getAsString()); } catch (Exception e) { - LOGGER.error(e.getClass().getSimpleName() + " " + e.getMessage()); - throw new ArcgisException("Unable to parse MultiPoint from json " + e.getMessage()); + LOGGER.error(e.getClass().getSimpleName() + " error " + e.getMessage() + " parsing MultiPoint from json " + json); + throw new ArcgisException("Unable to parse MultiPoint from json " + json + " due to " + e.getMessage()); } } diff --git a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Point.java b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Point.java index 8dab058f8..ddf18478c 100644 --- a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Point.java +++ b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Point.java @@ -142,8 +142,8 @@ public static Geometry createInstanceFromJson(JsonObject json) throws ArcgisExce return new Point(x, y, SpatialReference.WGS84); } catch (Exception e) { - LOGGER.error(e.getClass().getSimpleName() + " " + e.getMessage()); - throw new ArcgisException("Unable to parse Point from json " + e.getMessage()); + LOGGER.error(e.getClass().getSimpleName() + " error " + e.getMessage() + " parsing Point from json " + json); + throw new ArcgisException("Unable to parse Point from json " + json + " due to " + e.getMessage()); } } diff --git a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/PolyLine.java b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/PolyLine.java index bfc2ddcdb..af0211a64 100644 --- a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/PolyLine.java +++ b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/PolyLine.java @@ -133,8 +133,8 @@ public static Geometry createInstanceFromJson(JsonObject json) throws ArcgisExce try { return new PolyLine(json.get(PATHS_TAG).getAsString()); } catch (Exception e) { - LOGGER.error(e.getClass().getSimpleName() + " " + e.getMessage()); - throw new ArcgisException("Unable to parse PolyLine from json " + e.getMessage()); + LOGGER.error(e.getClass().getSimpleName() + " error " + e.getMessage() + " parsing PolyLine from json " + json); + throw new ArcgisException("Unable to parse PolyLine from json " + json + " due to " + e.getMessage()); } } diff --git a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Polygon.java b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Polygon.java index 4466831df..b8a2345c3 100644 --- a/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Polygon.java +++ b/cygnus-common/src/main/java/com/telefonica/iot/cygnus/backends/arcgis/model/Polygon.java @@ -133,8 +133,8 @@ public static Geometry createInstanceFromJson(JsonObject json) throws ArcgisExce try { return new Polygon(json.get(RINGS_TAG).getAsString()); } catch (Exception e) { - LOGGER.error(e.getClass().getSimpleName() + " " + e.getMessage()); - throw new ArcgisException("Unable to parse Polygon from json " + e.getMessage()); + LOGGER.error(e.getClass().getSimpleName() + " error " + e.getMessage() + " parsing Polygon from json " + json); + throw new ArcgisException("Unable to parse Polygon from json " + json + " due to " + e.getMessage()); } } From 89e372d472f678cbe04cf8e241d69a68deaedebc Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Wed, 25 Sep 2024 10:04:05 +0200 Subject: [PATCH 2/2] Update CHANGES_NEXT_RELEASE --- CHANGES_NEXT_RELEASE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE index d62de747d..59b4d59ad 100644 --- a/CHANGES_NEXT_RELEASE +++ b/CHANGES_NEXT_RELEASE @@ -1 +1 @@ -- [cygnus-ngsi][arcgis] Log json geometry before create instance +- [cygnus-ngsi][arcgis] Log json geometry before create instance and in errors related