From f2818abb1ce3768db367fa9a5bdfb7de16e9116c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferm=C3=ADn=20Gal=C3=A1n=20M=C3=A1rquez?= Date: Wed, 8 Nov 2023 14:03:35 +0100 Subject: [PATCH] FIX typos --- src/lib/parse/CompoundValueNode.cpp | 5 +++-- ...aluation_metadata_object_and_array_with_forcedUpdate.test | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/parse/CompoundValueNode.cpp b/src/lib/parse/CompoundValueNode.cpp index b66f011951..454c239383 100644 --- a/src/lib/parse/CompoundValueNode.cpp +++ b/src/lib/parse/CompoundValueNode.cpp @@ -530,7 +530,7 @@ std::string CompoundValueNode::check(const std::string& path) */ bool CompoundValueNode::equal(const orion::BSONElement& be) { - // Note object cannot be declared inside switch block + // Note objects cannot be declared inside switch block std::vector ba; orion::BSONObj bo; @@ -540,7 +540,8 @@ bool CompoundValueNode::equal(const orion::BSONElement& be) return (be.type() == orion::String) && (stringValue == be.String()); case orion::ValueTypeNumber: - // FIXME PR: unurure if this is going to work with all the Number types (int32/int64/double) + // FIXME P2: according to regression tests, this seems to work with all number types (int32/int64/double) + // However, let's keep an eye on this in the case some day it fails... return (be.type() == orion::NumberDouble && numberValue == be.Number()); case orion::ValueTypeBoolean: diff --git a/test/functionalTest/cases/4211_right_json_change_evaluation_in_subs/change_evaluation_metadata_object_and_array_with_forcedUpdate.test b/test/functionalTest/cases/4211_right_json_change_evaluation_in_subs/change_evaluation_metadata_object_and_array_with_forcedUpdate.test index a868b6576c..6a54735e5e 100644 --- a/test/functionalTest/cases/4211_right_json_change_evaluation_in_subs/change_evaluation_metadata_object_and_array_with_forcedUpdate.test +++ b/test/functionalTest/cases/4211_right_json_change_evaluation_in_subs/change_evaluation_metadata_object_and_array_with_forcedUpdate.test @@ -42,7 +42,7 @@ accumulatorStart --pretty-print # 06. Update E-A entity with same JSON array in metadata (notification) # 07. Update E-A entity with different JSON array in metadata (notification) # 08. Update E-A entity with same string in metadata (notification) -# 09. Dump accumulator, see 5 notifications +# 09. Dump accumulator, see 7 notifications # echo "01. Create subscription covering E-A"