Error returns from postUpdateContext

[kzangeli]

Right now it seems we have no less than three ways to return errors in the service routine postUpdateContext.

See postEntities.cpp, after the call to postUpdateContext:

• ciP->httpStatusCode
• parseDataP->upcrs.res.oe.code != SccNone
• parseDataP->upcrs.res.errorCode.code != SccNone (or similar)

It would be good to have one way of detecting errors, not three ...

[fgalan]

(PR #2821 is referred here, as there was a bug related with this issue that was fixed in that PR). The bug was:

attempt to create an entity with an error in service path (and probably more types of errors) now returns '400 Bad Request', not '200 OK'

[Anjali-NEC]

Hi @fgalan @kzangeli
I would like to work on this issue, please let me know this issue is still valid or not.

[fgalan]

The issue is still valid but before starting to implement it I think it needs a analysis phase to identify what to be exactly done. Thus maybe its better you choose another issue with a more straightforward task to do.

[fgalan]

After 4125c4d in PR #4603 (maybe even before?) there is only one way of returning in the service routine postUpdateContext, which is parseDataP->upcrs.res.oe.code != SccNone

For instance in postEntities() routine now we have:

  //
  // 03. Check error
  //
  std::string  answer = "";
  if (parseDataP->upcrs.res.error.code != SccOk)
  {
    ciP->httpStatusCode = parseDataP->upcrs.res.error.code;
    TIMED_RENDER(answer = parseDataP->upcrs.res.error.toJson());
    ciP->answer         = answer;
  }
  else
  {
  ...
  }

Thus this issue can be considered to be solved.