Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Ops: Cholesky decomposition #1078

Closed
ethanluoyc opened this issue Jan 10, 2019 · 1 comment
Closed

New Ops: Cholesky decomposition #1078

ethanluoyc opened this issue Jan 10, 2019 · 1 comment
Assignees
Labels
type:support user support questions

Comments

@ethanluoyc
Copy link

Hi!

I am trying to write an operator for computing Cholesky decomposition (and gradients).
It will roughly be based on the approach in TensorFlow (which is based on https://homepages.inf.ed.ac.uk/imurray2/pub/16choldiff/choldiff.pdf). I am half way through and
have created a PR tensorflow/tfjs-core#1492 but I think I need some help with a few details for implementing it. In particular
I would like to know

  1. What's the best way to copy the values of a tensor? I have tried tensor.clone() but apparently it does not do deep copying (Clone() doesn't actually clone? #1032).
  2. I would like to know how I can do in-place update to the content of the result tensor. The original code (in Numpy) does in place updates with a[:] = b but I don't know if there is a simple way to do this in tfjs. Right now I am just creating loops to iterate through the indices to do updates but is there a better way?

Thanks!

@rthadur rthadur added the type:support user support questions label Jan 10, 2019
@rthadur
Copy link
Contributor

rthadur commented Oct 15, 2019

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

@rthadur rthadur closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:support user support questions
Projects
None yet
Development

No branches or pull requests

3 participants