Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ad blocker doesn't work in latest version #1478

Closed
3 tasks done
skyisthela opened this issue Dec 2, 2023 · 16 comments
Closed
3 tasks done

[Bug]: ad blocker doesn't work in latest version #1478

skyisthela opened this issue Dec 2, 2023 · 16 comments
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version

Comments

@skyisthela
Copy link

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.0.1.0

What operating system are you using?

Windows

Operating System Version

Windows 20h2

What arch are you using?

x64

Last Known Working YouTube Music (Application) version

2.2.0

Reproduction steps

turn on ad blocker, doesn't work

Expected Behavior

ad blocker block ads

Actual Behavior

doesn't block ads

Enabled plugins

  1. ad blocker
  2. playback-speed

Additional Information

No response

@skyisthela
Copy link
Author

Had the same thing happening, disabling and enabling the Adblocker seemed to fixed it for me.

i did that, issue still persisted

@JellyBrick JellyBrick added the bug Something isn't working label Dec 2, 2023
@JellyBrick
Copy link
Collaborator

fixed in 3.0.2

@x3rt
Copy link

x3rt commented Dec 3, 2023

fixed in 3.0.2

Just had an ad on 3.0.2.0

@divStar
Copy link

divStar commented Dec 3, 2023

fixed in 3.0.2

Just had an ad on 3.0.2.0

Same (it was some iPhone 15 ad, that I could pause though and songs worked without ads It's occurring all the time now).

I suppose that's YT fighting ad-blockers and there'll be many more such things coming.

@JellyBrick JellyBrick reopened this Dec 3, 2023
@JellyBrick JellyBrick added the help wanted Extra attention is needed label Dec 3, 2023
@skyisthela
Copy link
Author

skyisthela commented Dec 3, 2023

curious but what ad block does this client use? ublock or some custom one?

@ArjixWasTaken
Copy link
Collaborator

ArjixWasTaken commented Dec 3, 2023

curious but what ad block does this client use? ublock or some custom one?

Two adblocking modes are available,

  • WithBlocklists: Uses the following blocking rules
  • InPlayer: From my understanding, it manipulates the JSON responses to remove ads. code

@inson1
Copy link
Contributor

inson1 commented Dec 3, 2023

I had same problem 6 times today - every time after restarting the app (about 80% change of ad) (in player option), but after that nothing

newest app version

Should I open another issue?

@JellyBrick
Copy link
Collaborator

JellyBrick commented Dec 3, 2023

This issue may have been caused by the "In player" script being injected too late (it was previously injected during the preload phase).

@inson1
Copy link
Contributor

inson1 commented Dec 3, 2023

Also it happens when reloading

@ovidiulixandru
Copy link

In-player blocking, I get ads in 3.0.2, but don't get them in 2.2.0.

@divStar
Copy link

divStar commented Dec 6, 2023

In-player blocking, I get ads in 3.0.2, but don't get them in 2.2.0.

I can confirm this.

@inson1
Copy link
Contributor

inson1 commented Dec 6, 2023

@divStar @ovidiulixandru on start or even later?

@divStar
Copy link

divStar commented Dec 6, 2023

In Version 2.2.0 I haven't had any ads at all (I am using it regularly on two Mac's), but then I upgraded to 3.0.2 and the ads appeared at the beginning and within a playlist of the same YouTube channel (Epic Music World).

@skyisthela
Copy link
Author

skyisthela commented Dec 7, 2023

i think at this point it's better to just use 2.2.0 youtube just keeps fighting ad blockers and the fact 2.2.0's ad blocking still works flawlessly is amazing.

also just a question but wouldn't it be possible to update and fix bugs but keep the ad block from 2.2.0? (i know nothing about code)

@JellyBrick
Copy link
Collaborator

JellyBrick commented Dec 7, 2023

We've already identified the cause of this issue and are working on a fix.
(see #1478 (comment))

@JellyBrick JellyBrick added fix-available A fix to the issue is available in a new version and removed help wanted Extra attention is needed labels Dec 11, 2023
@Helios747
Copy link

Helios747 commented Jun 27, 2024

This is still broken for me on v3.3.12 on Linux, MacOS Sonoma and Windows 11. In player adblocker lets ads slip. blocklists doesn't.

Unfortunately blocklists make the app notably less responsive.
image

another report here #2150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-available A fix to the issue is available in a new version
Projects
None yet
Development

No branches or pull requests

8 participants