Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3 objectstorage is not working for ap-south-2 region inspite of endpoint and region is mentioned and getting default to dualstack endpoint of us-east-1 #7427

Open
svvsmarutii opened this issue Jun 12, 2024 · 7 comments
Labels
package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore

Comments

@svvsmarutii
Copy link

svvsmarutii commented Jun 12, 2024

Thanos, Prometheus and Golang version used: 0.30.2

Object Storage Provider: AWS S3

What happened: Thanos sidecar, compact, query, storegateway components are trying to reach the S3 bucket in us-east-1 region inspite ap-south-2 region and s3 endpoint is set.

What you expected to happen: Thanos components should reach S3 bucket to the region(ap-south-2) as mentioned in the thanos helm chart

How to reproduce it (as minimally and precisely as possible): Deploy the thanos helm chart with below objectstorage.yaml configuration
objstoresecret:
type: s3
prefix: thanos
config:
bucket: "dev-dr-thanos-metrics"
region: ap-south-2
endpoint: s3.ap-south-2.amazonaws.com

Full logs to relevant components:
image

Anything else we need to know:
Able to see the s3 endpoint of ap-south-2 is supported by thanos https://docs.aws.amazon.com/general/latest/gr/s3.html

@harry671003
Copy link
Contributor

I think this issue was raised in: #6541
You should probably use a more newer version of Thanos for the minio update to be included.

@Sahana-Nagaraja
Copy link

Hi @harry671003, I am a colleague of Maruthi. We have upgraded Thanos to 0.35.1 and now we see that Thanos is pointing to right region. But, it is trying to access dualstack endpoint of S3 bucket which is not available yet. We did not manage to find a parameter to set it to use standalone S3 endpoint in Thanos helm chart. Can you please help us here if you have a handy solution?

@douglascamata
Copy link
Contributor

douglascamata commented Jun 14, 2024

Sounds like this was fixed in the objstore lib (see thanos-io/objstore#112) by allowing the dualstack endpoint to be disabled. So we only need to bump the dependency here in Thanos.

@douglascamata douglascamata added the package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore label Jun 14, 2024
@svvsmarutii
Copy link
Author

Hi @douglascamata Thanks for update. Is it possible to provide an ETA for this change to be available in thanos ? Also, is there a quick workaround that we could do to leverage this option ?

@harry671003
Copy link
Contributor

harry671003 commented Jun 15, 2024

#7462 - Update objstore

@harry671003
Copy link
Contributor

My PR to update the objstore version in Thanos got merged.
@svvsmarutii - could you try testing with the latest image of Thanos?
As douglascamata pointed out, setting disable_dualstack: true in the config should fix this problem.

@douglascamata
Copy link
Contributor

@svvsmarutii we don't provide ETAs for changes, as it depends on the "free work" of maintainers that might be busy with their jobs. But, as the PR was already merged, it should be going out in the next Thanos release. If you would like to have a bugfix release, please reach out in #thanos-dev in the CNCF slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore
Projects
None yet
Development

No branches or pull requests

4 participants