Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use toODOPPrecision() for Cycle_Life in coil spring reports #893

Open
grumpyinca opened this issue Dec 11, 2023 · 0 comments
Open

Use toODOPPrecision() for Cycle_Life in coil spring reports #893

grumpyinca opened this issue Dec 11, 2023 · 0 comments
Assignees
Milestone

Comments

@grumpyinca
Copy link
Contributor

Currently, the coil spring reports render the value of Cycle Life as:
{this.props.symbol_table[o.Cycle_Life].value.toFixed(0)}</td>

This was a reasonable choice when Cycle_life was limited to the range of 1 to 1e7 cycles. The system now needs to render a much broader range (roughly Number.MINVALUE to Number.MAXVALUE). Rendering the extreme values with toFixed() messes up the formatting. The results will look better if toFixed() is replaced with toODOPPrecision().

@grumpyinca grumpyinca added this to the ODOP 4.8 milestone Dec 11, 2023
@grumpyinca grumpyinca self-assigned this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant