fixed bug in training of only loc or scale model in numpy

theislab · Feb 26, 2020 · d3287b3 · d3287b3
1 parent 4f19e21
commit d3287b3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/batchglm/train/numpy/base_glm/estimator.py b/batchglm/train/numpy/base_glm/estimator.py
@@ -123,7 +123,7 @@ def train(
                     b_var_new[:, idx_bad_step] = b_var_new[:, idx_bad_step] - b_step[:, idx_bad_step]
                     self.model.b_var = b_var_new
                 else:
-                    ll_proposal = ll_current
+                    ll_proposal = ll_current[idx_update]
                     idx_bad_step = np.array([], dtype=np.int32)
                 # Update likelihood vector with updated genes based on already evaluated proposal likelihood.
                 ll_new = ll_current.copy()
@@ -149,7 +149,7 @@ def train(
                     a_var_new[:, idx_bad_step] = a_var_new[:, idx_bad_step] - a_step[:, idx_bad_step]
                     self.model.a_var = a_var_new
                 else:
-                    ll_proposal = ll_current
+                    ll_proposal = ll_current[idx_update]
                     idx_bad_step = np.array([], dtype=np.int32)
                 # Update likelihood vector with updated genes based on already evaluated proposal likelihood.
                 ll_new = ll_current.copy()