Exclude neighbours of the ref_index in DISE algorithm #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FanwangM and @marco-2023, the tests currently fail. If you agree with this change, I will update the tests. Just to let you know the OptiSim algorithm adds |
|
It looks good to me. Thanks for fixing this. |
marco-2023
reviewed
Jul 2, 2024
| # construct KDTree for quick nearest-neighbor lookup | ||
| kdtree = scipy.spatial.KDTree(X) | ||
|
|
||
| # construct bitarray to track selected samples (1 means exclude) | ||
| bv = bitarray.bitarray(list(np.zeros(len(X), dtype=int))) | ||
| bv[self.ref_index] = 1 |
There was a problem hiding this comment.
In the new code self.ref_index is also returned among the selected elements. Is this intended?
There was a problem hiding this comment.
note to myself: it is consistent with OptiSim
marco-2023
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DISE algorthim, the
ref_indexwas not included as a selected sample, and its neighbors were not excluded. I believe this was not a desired feature, so this PR fixed that. Feel Free to let me know what you think.