Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DiacriticsOptions.Decompose on README.md #44

Open
moon6969 opened this issue Mar 19, 2022 · 3 comments
Open

Document DiacriticsOptions.Decompose on README.md #44

moon6969 opened this issue Mar 19, 2022 · 3 comments

Comments

@moon6969
Copy link

I couldn't figure out why ß wasn't being removed until I poked through the source.

Might be nice to give a Decompose example in the README.md.

@thomasgalliker
Copy link
Owner

Oh, yes. I’m going to add something to the readme. However, I’m pretty stuffed with other tasks; it might take some time. But thanks!

@brian-tumibay
Copy link

"Buchenstraße".RemoveDiacritics() // this doesn't work, output is the same

string sample = "Buchenstraße"; DiacriticsOptions options = new DiacriticsOptions(); options.Decompose = true; Console.WriteLine(DiacriticsMapper.Current.RemoveDiacritics("ß", options)); // output: empty Console.WriteLine(DiacriticsMapper.Current.RemoveDiacritics(sample, options)); // output: Buchenstrasse

I hope you update the README.md

@thomasgalliker
Copy link
Owner

@brian-tumibay thanks for the hint. Pull requests are welcome, also for documentation related stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants