Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature Request: OCR areas history #461

Open
thesla13 opened this issue Mar 18, 2024 · 2 comments
Open

🚀 Feature Request: OCR areas history #461

thesla13 opened this issue Mar 18, 2024 · 2 comments
Labels
enhancement New feature or request todo

Comments

@thesla13
Copy link

thesla13 commented Mar 18, 2024

Hey there!

Sometimes when using EasyDict I would OCR the same area of the screen over and over again. For instance, when looking up subtitles hardcoded into a video-file. So this means I have to select the same area by hand, over and over and over again, which does become tedious.

Now, some screenshot tools like Snipaste keep area history for cases when you make screenshots of the same area repeatedly. Snipaste, for instance, lets you press the 'R' key to reselect the last area shot, then, if need be, press 'R' again to select the one before that, and so on.

I do think that keeping a history of OCR'ed areas would be a nice quality-of-life improvement for EasyDict.

Thank you so much for your work!

@thesla13 thesla13 added the enhancement New feature or request label Mar 18, 2024
@tisfeng
Copy link
Owner

tisfeng commented Mar 20, 2024

Thanks for the suggestion, a similar request #22 has been made before, but I didn't find this the right way to add this feature, so I've shelved it.

Previously my idea was to add an additional shortcut specifically for triggering the previous history screenshot area.

Snipaste, for instance, lets you press the 'R' key to reselect the last area shot, then, if need be, press 'R' again to select the one before that, and so on.

Now you give us another good suggestion, we will evaluate these two ways of implementation.

@tisfeng
Copy link
Owner

tisfeng commented Mar 20, 2024

The previous screenshot OCR feature was implemented using a third-party objc library, and the code was quite messy, which may cause memory leakage issues.

Later, we plan to rewrite it using Swift, which may take some time. Please be patient.

If someone is familiar with the screenshot feature in Swift, we warmly welcome you to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo
Projects
None yet
Development

No branches or pull requests

2 participants