Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication when collecting dependencies #328

Open
jrmaddison opened this issue Aug 23, 2023 · 0 comments
Open

Reduce code duplication when collecting dependencies #328

jrmaddison opened this issue Aug 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jrmaddison
Copy link
Collaborator

Collection of dependencies, together with a map from IDs to dependency indices, appears in a number of places. This at least includes:

  • FixedPointSolver
  • LinearEquation
  • MatrixActionRHS

This could be significantly simplified using a simple class to gather the dependencies, and extra Equation methods to map from symbolic dependencies to dependency values.
@jrmaddison jrmaddison added the enhancement New feature or request label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrmaddison