Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh coordinates annotation #427

Open
jrmaddison opened this issue Nov 2, 2023 · 1 comment
Open

Mesh coordinates annotation #427

jrmaddison opened this issue Nov 2, 2023 · 1 comment
Labels
enhancement New feature or request Firedrake backend

Comments

@jrmaddison
Copy link
Collaborator

Should be a simple change to EquationSolver, but tests needed, and the coordinates must having caching enabled by default.
@jrmaddison jrmaddison added enhancement New feature or request Firedrake backend labels Nov 2, 2023
@jrmaddison
Copy link
Collaborator Author

Some experiments suggest this is reasonably straightforward. The coordinates Function can be flagged, and then detected by the derivative function. Currently tlm_adjoint differentiates first, then uses ufl.replace. This order needs to be reversed for spatial coordinate derivatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Firedrake backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrmaddison