Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace_map
when generating cache entries, are now included in the key.var_update_state
now clears associated cache entries.var_update_caches
calls. This catches all cache invalidation visible to tlm_adjoint -- which with the Firedrake backend includes any updates to dat versions, even those that do not have associatedvar_update_state
calls.A better alternative to 3 is to make hashing cheap and then simply check the caches every time -- but this needs #183 in order to avoid leaking memory when applying checkpointing.