Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Invitation Using a Link is Broken #2298

Open
AgentOren opened this issue May 5, 2024 · 2 comments
Open

User Invitation Using a Link is Broken #2298

AgentOren opened this issue May 5, 2024 · 2 comments
Assignees

Comments

@AgentOren
Copy link

I just tried to invite an existing user to a new project on a self-hosted instance (Version: v3.59.7). When the user tries to login using the link, he receives an "Unexpected error occurred" popup, an the following error is logged:

2024-05-05T11:29:43.935Z  INFO 1 --- [io-8080-exec-21] o.apache.coyote.http11.Http11Processor   : Error parsing HTTP request header
 Note: further occurrences of HTTP request parsing errors will be logged at DEBUG level.

java.lang.IllegalArgumentException: Invalid character found in the request target [/v2/invitations/"vPpsTouKJelCvAqWSJfRvGWlzmrFKyzdiKnWakQVUhLxANMXMt"/accept ]. The valid characters are defined in RFC 7230 and RFC 3986
        at org.apache.coyote.http11.Http11InputBuffer.parseRequestLine(Http11InputBuffer.java:490) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:264) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:896) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1744) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-10.1.15.jar:10.1.15]
        at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]

It seems to me like the quotes around the token in the URL are redundant. I don't remember such behavior in the past, so I suspect it's a regression in recent versions.

@stepan662 stepan662 self-assigned this May 6, 2024
@stepan662
Copy link
Contributor

Hey, does this happen always? I was not able to replicate

@AgentOren
Copy link
Author

My specific use case was:

  • Tolgee internal authentication
  • A user was already invited to another project, but non member of an organization.
  • Happened when attempted to invite the user to a second (newly created) project.
  • Also happened when attempted to invite the user to an organization.

Hope one of the above may assist in reproducing the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants