Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marlinspike doesn't inject elements #112

Open
stratboy opened this issue Nov 12, 2015 · 7 comments
Open

Marlinspike doesn't inject elements #112

stratboy opened this issue Nov 12, 2015 · 7 comments

Comments

@stratboy
Copy link

Hi, I'm currently on sails 0.11.2. Using a fresh test sails app. I've installed marlinkspike. Then sails-auth. But the auxiliary sails-auth services, controllers etc don't get injected. Also, I guess as a consequence, upon lifting I get this kind of error:

[...]
/node_modules/sails-auth/api/hooks/sails-auth.js:4
      sails.services.passport.loadStrategies();
                             ^

TypeError: Cannot read property 'loadStrategies' of undefined
[...]

Any idea?

@tjwebb
Copy link
Member

tjwebb commented Nov 12, 2015

The latest version of sails-auth currently only works with balderdashy/sails on master.

For compatibility with sails 0.11, use sails-auth 1.3.x series.

@stratboy
Copy link
Author

ok thank you

@stratboy
Copy link
Author

installed 1.3.1 but same problem. Same error and also marlinspike seems not to work. Here's my current deps list:

"ejs": "~0.8.4",
"grunt": "0.4.2",
"grunt-contrib-clean": "~0.5.0",
"grunt-contrib-coffee": "~0.10.1",
"grunt-contrib-concat": "~0.3.0",
"grunt-contrib-copy": "~0.5.0",
"grunt-contrib-cssmin": "~0.9.0",
"grunt-contrib-jst": "~0.6.0",
"grunt-contrib-less": "0.11.1",
"grunt-contrib-uglify": "~0.4.0",
"grunt-contrib-watch": "~0.5.3",
"grunt-sails-linker": "~0.9.5",
"grunt-sync": "~0.0.4",
"include-all": "~0.1.3",
"jade": "^1.11.0",
"marlinspike": "^0.12.15",
"passport": "^0.3.2",
"passport-facebook": "^2.0.0",
"passport-local": "^1.0.0",
"rc": "~0.5.0",
"sails": "~0.11.2",
"sails-auth": "^1.3.1",
"sails-disk": "~0.10.0"

@kevintechie
Copy link

According to the docs, marlinspike is not compatible with sails 0.11.

@stratboy
Copy link
Author

Mmm you're right, ok. Given that, so I should use sails-auth only with sails v0.12.x? But it's not currently released, so, not production ready, I guess?

@tjwebb
Copy link
Member

tjwebb commented Nov 15, 2015

@stratboy marlinspike is not even used in sails-auth 1.3.x, so there's no way you're seeing that error on sails-auth 1.3.1. Make sure you've got the right node modules installed.

@stratboy
Copy link
Author

Ok thank you, but is sails v0.12 (so with sails-auth + marlinspike) already somewhat suitable for production? In fact, I'm using it for a small side project that it will go live in no less than some months from now. Could I maybe already stick on v0.12?

Travis Webb wrote:

@stratboy https://github.com/stratboy marlinspike is not even used
in sails-auth 1.3.x, so there's no way you're seeing that error on
sails-auth 1.3.1. Make sure you've got the right node modules installed.


Reply to this email directly or view it on GitHub
#112 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants