Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn user if an ORM is not installed, but footprints are enabled #33

Open
tjwebb opened this issue Jan 22, 2016 · 5 comments
Open

warn user if an ORM is not installed, but footprints are enabled #33

tjwebb opened this issue Jan 22, 2016 · 5 comments

Comments

@tjwebb
Copy link
Member

tjwebb commented Jan 22, 2016

If no ORM is installed but config.footprints.models is configured, then FootprintService will likely not exist and the footprint routes will crash.

@jaumard
Copy link
Contributor

jaumard commented Jan 22, 2016

Maybe this can be done under trailpack-router instead of hapi/express/koa.... ?

@jaumard
Copy link
Contributor

jaumard commented Apr 9, 2016

It can be done under validate method of trailpack-footprints

@weyj4
Copy link
Member

weyj4 commented Apr 18, 2016

Does this mean we can close this issue w/r/t trailpack-hapi?

@weyj4
Copy link
Member

weyj4 commented Apr 20, 2016

@jaumard can we close the issue?

@jaumard
Copy link
Contributor

jaumard commented Apr 20, 2016

If we move the issue on another repo yes. There multiple choice for this :

trailpack-router can check this, warn user and ignore routes to not have crashing routes
or
trailpack-footprints can check this and warn user, but routes will crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants