Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File watching does not detect change inside loop block of input step? #820

Open
e-gineer opened this issue Mar 29, 2024 · 2 comments
Open
Labels
bug Something isn't working stale

Comments

@e-gineer
Copy link
Contributor

Version: v0.4.3-rc.2

I have this step:

  step "input" "approve" {
    notifier = notifier[param.approvers[0]]

    type = "button"

    subject = param.subject

    prompt = param.prompt

    option "approve" {
      label = "Approve"
      style = "ok"
    }

    option "deny" {
      label = "Deny"
      style = "alert"
    }

    loop {
      until = result.value == "deny" || loop.index >= length(param.approvers) - 1
      notifier = notifier[param.approvers[loop.index]]
    }

    output "approved" {
      value = self.value == "approve"
    }

  }

When I change the loop until attribute (e.g. add or remove the - 1), the file watching does not detect the change.

File watching works and reloads for changes to the option style attribute (as expected).

@e-gineer e-gineer added the bug Something isn't working label Mar 29, 2024
@vhadianto
Copy link
Contributor

Fixed in pipe-fittings: turbot/pipe-fittings@27d7c59

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants