Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression since v3.9.0 #4103

Open
vbrouet opened this issue May 30, 2024 · 1 comment
Open

Performance regression since v3.9.0 #4103

vbrouet opened this issue May 30, 2024 · 1 comment

Comments

@vbrouet
Copy link

vbrouet commented May 30, 2024

          What is the performance impact of the runtime check combined with yield ?

Originally posted by @stof in #3999 (review)

Hello,

While investigating a performance regression in a symfony app (6.4) I found that the source was twig/twig version 3.9.0.

I made a small repro and used git bissect to find this pull request #3999 where performance is briefly discussed.

After some trial and error, performance was partially restored by passing 'use_yield' => true to the twig Environment constructor.

Not sure if this is a bug but in certain cases the performance impact was pretty huge (from 800 ms to 2200ms).

@vbrouet vbrouet changed the title What is the performance impact of the runtime check combined with yield ? Performance regression since v3.9.0 May 30, 2024
@j0r1s
Copy link

j0r1s commented Jun 2, 2024

Probably related to this discussion I opened a few days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants