Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup: Replaced 'idx' with '_'. Removed unused parameter & unused import #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

faeezshaikh
Copy link

@faeezshaikh faeezshaikh commented Apr 1, 2023

  1. The idx variable is not used in the code after it is defined, so it can be removed without affecting the behavior of the code. The idx should be replaced with _. This will indicate that the loop variable is not used, while still iterating over num_examples times.

  2. Removed unused parameter from the get_readers(). The num_readers_per_worker parameter is not being used inside the get_readers function, and it appears to be an unused parameter. The function creates one reader per worker, so num_readers_per_worker does not seem to have any effect on the behavior of the function. It's possible that this parameter was intended to be used in some way but was later removed or overlooked. Therefore, num_readers_per_worker appears to be an unnecessary parameter and can be removed from the function signature.

  3. Removed unused import LocalFileSystem. LocalFileSystem from fsspec.implementations.local is imported but not used in the code.

@faeezshaikh faeezshaikh changed the title Removed unused parameter and unused import Code cleanup: Replaced 'idx' with '_'. Removed unused parameter & unused import Apr 1, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Faeez Shaikh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants