Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve statistics output modstatsdump.f90 #57

Open
1 of 6 tasks
bss116 opened this issue Jan 16, 2020 · 1 comment
Open
1 of 6 tasks

Improve statistics output modstatsdump.f90 #57

bss116 opened this issue Jan 16, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@bss116
Copy link
Contributor

bss116 commented Jan 16, 2020

This issue addresses code improvement and further functionalities for the statistics routine modstatsdump.f90.
Code improvement: The code has currently some statistics calculations hardcoded for each variable. This should be replaced by generic functions and function calls for the variables. Care needs to be taken about static or dynamic allocation of output arrays, when the number of output variables is only determined at runtime.
Additional features: Adding the block masks as statistics output can be useful for post-processing.
Currently the lowest (floor) level is masked in the statistics output. I would suggest to instead not output it at all and move the z-axes accordingly.

Summary of tasks:

  • change to generic statistics functions and calls for output variables

  • automate routine for non-neutral and/or scalar statistics output (Automate modstatsdump #42)

  • add forcing to output (Assign flow forcing in namoptions #48)

  • add block masks to output

  • remove masked entries

  • only output variables that are actually calculated

@tomgrylls
Copy link
Contributor

As opposed to creating some automated way of changing the size of the netcdf files depending on switches like ltempeq, lmoist etc. A potentially simpler change would be to separate these output files completely. As opposed to having tdump.xxx.nc with all outputs of interest, we have m.tdump.xxx.nc (momentum), T.tdump.xxx.nc (temperature), s1.tdump.xxx.nc (first scalar field) etc. And so on for ytdump, xytdump etc.? This relates to #42.

@bss116 bss116 added the enhancement New feature or request label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants