Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further namoptions cleanup #66

Open
1 of 31 tasks
bss116 opened this issue Mar 30, 2020 · 4 comments
Open
1 of 31 tasks

Further namoptions cleanup #66

bss116 opened this issue Mar 30, 2020 · 4 comments
Labels
Milestone

Comments

@bss116
Copy link
Contributor

bss116 commented Mar 30, 2020

This issue is about cleaning up the list of parameters that can be set in the namoptions input file. There are a few points up for discussion (we might also want to break them into separate issues):

&RUN

  • lles = .true. Discuss whether to remove non-LES functionality
  • randu = 0. Default changed from 0.5 in DALES. Should we change back?
  • randthl = 0. Default changed from 0.1 in DALES. Should we change back?
  • randqt = 0. Default changed from 1e-5 in DALES. Should we change back?
  • courant = -1 Code sets it to 1.5 or 1.1 (if Kappa or upwind scheme is used). These are different values than in DALES!
  • diffnr = 0.25 Diffusion number? Used to determine adaptive time step. Can we get rid of it?
  • lreadmean = .false. Potentially deprecated. Should we remove it?
  • lper2inout = .false. Potentially deprecated. Should we remove it?
  • lwalldist = .false. Switch to calculate wall effects for the subgrid models (Smagorinsky or one equation). Potentially deprecated. Should we remove it?
  • lstratstart = .false. Description missing.

&BC

  • wtsurf = -1. What to do with subroutine bottom?
  • wqsurf = -1.
  • thls = -1.
  • z0 = -1.
  • z0h = -1.
  • !wsvsurfdum = Should be reviewed when checking scalars implementation
  • !wsvtopdum =

&WALLS

  • iwallmom = 2 Should we set default to 3? (neutral wall function) Will need to test this first! Edit: We decided to remove option 3 from the user documentation as the code chooses this automatically for neutral simulations

&PHYSICS

  • igrw_damp = 2 Gravity wave dumping. We use = 0 (no damping).

&DYNAMICS

  • iadv_tke = -1 Only applicable if loneeqn = True. Consider removing this option?
  • iadv_qt = -1 Should we extend and test use of option 7 (Kappa scheme)?
  • iadv_sv = -1 Consider removing option 1 (upwind scheme)?
  • ipoiss = 1 Should be set to ipoiss = 0 when bug in EB is fixed (Issue FFT not working with energy balance #61).

&NAMSUBGRID

  • loneeqn = .false. Should we remove this?

&INLET

  • linletRA = .false. These parameters are associated with the turbulent inlet generation. They are untested with the current version of the code. Remove or update?
  • lfixinlet = .false.
  • lfixutauin = .false.

&SCALARS

  • lreadscal = .false. Deprecated, should we remove?
  • lscasrc = .false. Description missing
  • lscasrcl = .false. Description missing

general:

  • ensure consistent spacing before and after = when namoptions are changed by da_inp.sh and da_prep.sh.
@bss116 bss116 added this to the 0.2.0 milestone Mar 30, 2020
@tomgrylls

This comment has been minimized.

@tomgrylls tomgrylls mentioned this issue Apr 23, 2020
@bss116

This comment has been minimized.

@tomgrylls

This comment has been minimized.

@tomgrylls

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants