Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Improve socket selection when there are no incoming sockets #187

Open
Matt-Esch opened this issue Nov 5, 2015 · 2 comments
Open

Improve socket selection when there are no incoming sockets #187

Matt-Esch opened this issue Nov 5, 2015 · 2 comments

Comments

@Matt-Esch
Copy link
Contributor

If the provided host list is large and there are not incoming connections, tchannel exhaustively connects to all of the nodes in the host list regardless of the necessity to do this.

I think this behavior needs to be improved for services that are consuming from tchannel services and not advertising themselves. This effectively means an improvement in the peer selection code. lb_pool avoids connecting to the entire host list by favoring open connections and supplying a max sockets option.

@Matt-Esch
Copy link
Contributor Author

cc: @Raynos

@Raynos
Copy link
Contributor

Raynos commented Nov 5, 2015

This is a good idea.

At the same time; everyone should advertise().

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants